On Thu, 15 Jun 2017 08:13:09 -0400, Adam Duskett wrote:
> janus-gateway supports many different transports, and currently
> there is no implicit way to turn them off or on. Instead, if the
> dependency happens to be built, then the transport is enabled.
> Create a transports section in the config file and add
> BR2_PACKAGE_JANUS_REST as the first transport.
> Signed-off-by: Adam Duskett <[hidden email]>
> package/janus-gateway/Config.in | 6 ++++++
> package/janus-gateway/janus-gateway.mk | 7 +++++++
> 2 files changed, 13 insertions(+)
I've applied patches 2 to 7. However, it would be nice to be a little
bit more careful in the patches. I had to fix a few things:
* The title had a typo in most of the commits: gatway -> gateway
* Inconsistent ending of the titles: some ending with a final dot,
some not. The latter being the preferred choice.
* You forgot to propagate the dependencies of the packages being
selected, and adding the corresponding Config.in comment.
* You forgot to use alphabetic ordering where appropriate.
All those are minor nits, but they add up, and need to be fixed before
applying the patches.