[PATCH 1/1] kvazaar: new package

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[PATCH 1/1] kvazaar: new package

Alexandre Esse
Kvazaar is an open-source HEVC encoder licensed under LGPLv2.1.
This provides tools to encode raw video into HEVC stream.

website: http://ultravideo.cs.tut.fi/

Signed-off-by: Alexandre Esse <[hidden email]>
---
 DEVELOPERS                   |  2 +
 package/Config.in            |  1 +
 package/kvazaar/Config.in    |  4 ++++
 package/kvazaar/kvazaar.hash |  1 +
 package/kvazaar/kvazaar.mk   | 14 ++++++++++++++
 5 files changed, 21 insertions(+)
 create mode 100644 package/kvazaar/Config.in
 create mode 100644 package/kvazaar/kvazaar.hash
 create mode 100644 package/kvazaar/kvazaar.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index 6f752cb..c45a09d 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -65,6 +65,7 @@ N: Alexandre Belloni <[hidden email]>
 F: package/tz/
 
+N: Alexandre Esse <[hidden email]>
+F: package/kvazaar/
 
 N: Alistair Francis <[hidden email]>
diff --git a/package/Config.in b/package/Config.in
index 95604ed..236c865 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1220,6 +1220,7 @@ endmenu
 
 menu "Multimedia"
  source "package/bitstream/Config.in"
+ source "package/kvazaar/Config.in"
  source "package/libaacs/Config.in"
  source "package/libamcodec/Config.in"
  source "package/libass/Config.in"
diff --git a/package/kvazaar/Config.in b/package/kvazaar/Config.in
new file mode 100644
index 0000000..a720f17
--- /dev/null
+++ b/package/kvazaar/Config.in
@@ -0,0 +1,4 @@
+config BR2_PACKAGE_KVAZAAR
+ bool "kvazaar"
+ help
+                An open-source HEVC encoder licensed under LGPLv2.1
diff --git a/package/kvazaar/kvazaar.hash b/package/kvazaar/kvazaar.hash
new file mode 100644
index 0000000..1f3b65f
--- /dev/null
+++ b/package/kvazaar/kvazaar.hash
@@ -0,0 +1 @@
+sha256 8e382738a51004bfcfca4c832e8b41fe6a17f889f3c39151dc1c1a37261a3a6d  kvazaar-v1.1.0.tar.gz
diff --git a/package/kvazaar/kvazaar.mk b/package/kvazaar/kvazaar.mk
new file mode 100644
index 0000000..0d9eadb
--- /dev/null
+++ b/package/kvazaar/kvazaar.mk
@@ -0,0 +1,14 @@
+################################################################################
+#
+# kvazaar
+#
+################################################################################
+
+KVAZAAR_VERSION = v1.1.0
+KVAZAAR_SITE = $(call github,ultravideo,kvazaar,$(KVAZAAR_VERSION))
+KVAZAAR_LICENSE = LGPLv2.1
+KVAZAAR_LICENSE_FILES = COPYING
+KVAZAAR_AUTORECONF = YES
+KVAZAAR_INSTALL_STAGING = YES
+
+$(eval $(autotools-package))
--
2.7.4

_______________________________________________
buildroot mailing list
[hidden email]
http://lists.busybox.net/mailman/listinfo/buildroot
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH 1/1] kvazaar: new package

Thomas Petazzoni-2
Hello,

On Sat, 17 Jun 2017 01:29:27 +0200, Alexandre Esse wrote:
> Kvazaar is an open-source HEVC encoder licensed under LGPLv2.1.
> This provides tools to encode raw video into HEVC stream.
>
> website: http://ultravideo.cs.tut.fi/
>
> Signed-off-by: Alexandre Esse <[hidden email]>

I've applied, after doing a few changes. See below.

> diff --git a/package/kvazaar/Config.in b/package/kvazaar/Config.in
> new file mode 100644
> index 0000000..a720f17
> --- /dev/null
> +++ b/package/kvazaar/Config.in
> @@ -0,0 +1,4 @@
> +config BR2_PACKAGE_KVAZAAR
> + bool "kvazaar"
> + help
> +                An open-source HEVC encoder licensed under LGPLv2.1

Indentation for the help text is one tab + two spaces. Also, the
Config.in help text should have an URL of the upstream project.

Please run your package submissions through
support/scripts/check-package, it detects this kind of mistakes.

> +KVAZAAR_VERSION = v1.1.0
> +KVAZAAR_SITE = $(call github,ultravideo,kvazaar,$(KVAZAAR_VERSION))
> +KVAZAAR_LICENSE = LGPLv2.1

It's in fact LGPLv2.1+, and we use SPDX license codes in Buildroot, so
LGPL-2.1+.

> +KVAZAAR_LICENSE_FILES = COPYING
> +KVAZAAR_AUTORECONF = YES
> +KVAZAAR_INSTALL_STAGING = YES

I've added KVAZAAR_CONF_OPTS = --without-cryptopp to make sure it
doesn't pick up this optional dependency, as it's not explicitly
handled by kvazaar.mk.

Thanks!

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
_______________________________________________
buildroot mailing list
[hidden email]
http://lists.busybox.net/mailman/listinfo/buildroot
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH 1/1] kvazaar: new package

Alexandre Esse
Thank you for you feedback.

I am still novice into Buildroot. Even if I read the documentation, I didn't know about support/scripts/check-package. Maybe, It should appear in the new package submission part of the documentation?

About the cryptopp part, I have already the option --with-cryptopp working on my PC with a custom cryptopp recipe I now need to patch the already existing cryptopp package for it ;)

Alexandre

On 18 June 2017 at 22:05, Thomas Petazzoni <[hidden email]> wrote:
Hello,

On Sat, 17 Jun 2017 01:29:27 +0200, Alexandre Esse wrote:
> Kvazaar is an open-source HEVC encoder licensed under LGPLv2.1.
> This provides tools to encode raw video into HEVC stream.
>
> website: http://ultravideo.cs.tut.fi/
>
> Signed-off-by: Alexandre Esse <[hidden email]>

I've applied, after doing a few changes. See below.

> diff --git a/package/kvazaar/Config.in b/package/kvazaar/Config.in
> new file mode 100644
> index 0000000..a720f17
> --- /dev/null
> +++ b/package/kvazaar/Config.in
> @@ -0,0 +1,4 @@
> +config BR2_PACKAGE_KVAZAAR
> +     bool "kvazaar"
> +     help
> +                An open-source HEVC encoder licensed under LGPLv2.1

Indentation for the help text is one tab + two spaces. Also, the
Config.in help text should have an URL of the upstream project.

Please run your package submissions through
support/scripts/check-package, it detects this kind of mistakes.

> +KVAZAAR_VERSION = v1.1.0
> +KVAZAAR_SITE = $(call github,ultravideo,kvazaar,$(KVAZAAR_VERSION))
> +KVAZAAR_LICENSE = LGPLv2.1

It's in fact LGPLv2.1+, and we use SPDX license codes in Buildroot, so
LGPL-2.1+.

> +KVAZAAR_LICENSE_FILES = COPYING
> +KVAZAAR_AUTORECONF = YES
> +KVAZAAR_INSTALL_STAGING = YES

I've added KVAZAAR_CONF_OPTS = --without-cryptopp to make sure it
doesn't pick up this optional dependency, as it's not explicitly
handled by kvazaar.mk.

Thanks!

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


_______________________________________________
buildroot mailing list
[hidden email]
http://lists.busybox.net/mailman/listinfo/buildroot
Loading...