[PATCH 0/2] at: bump version

classic Classic list List threaded Threaded
23 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[PATCH 0/2] at: bump version

Giulio Benetti
As suggested at https://elinux.org/Buildroot#Todo_list:
"Update the at package to use the upstream.
http://anonscm.debian.org/gitweb/?p=collab-maint/at.git;a=summary"
In the meanwhile that site became unreachable and the at upstream now is:
https://salsa.debian.org/debian/at

These are the basic tasks done:
- change upstream site, bump version
- add sha256 for legal-info files

Giulio Benetti (2):
  at: change upstream site, bump version
  at: add sha256 for legal-info files

 ...-Makefile-fix-parallel-build-failure.patch | 33 +++++++++++++++++++
 package/at/at.hash                            |  7 ++--
 package/at/at.mk                              |  9 ++---
 3 files changed, 43 insertions(+), 6 deletions(-)
 create mode 100644 package/at/0007-Makefile-fix-parallel-build-failure.patch

--
2.17.1

_______________________________________________
buildroot mailing list
[hidden email]
http://lists.busybox.net/mailman/listinfo/buildroot
Reply | Threaded
Open this post in threaded view
|

[PATCH 1/2] at: change upstream site, bump version

Giulio Benetti
Minicom is now available on a git repository at:
https://salsa.debian.org/debian/at
Main changes 3.1.16 -> 3.1.23:
- add support for SELinux, multiple files
- improve atd.service, see bug report 892819
- fix various bugs and warnings
- finalized script to release software

So:
- change AT_SITE_METHOD to git pointing to release/3.1.23
- update tarball sha256 in hash file

Signed-off-by: Giulio Benetti <[hidden email]>
---
 ...-Makefile-fix-parallel-build-failure.patch | 33 +++++++++++++++++++
 package/at/at.hash                            |  4 +--
 package/at/at.mk                              |  9 ++---
 3 files changed, 40 insertions(+), 6 deletions(-)
 create mode 100644 package/at/0007-Makefile-fix-parallel-build-failure.patch

diff --git a/package/at/0007-Makefile-fix-parallel-build-failure.patch b/package/at/0007-Makefile-fix-parallel-build-failure.patch
new file mode 100644
index 0000000000..145e8fa8c9
--- /dev/null
+++ b/package/at/0007-Makefile-fix-parallel-build-failure.patch
@@ -0,0 +1,33 @@
+From 5b98a3166ddc03dbe040bef2de464166a5b7ab78 Mon Sep 17 00:00:00 2001
+From: Giulio Benetti <[hidden email]>
+Date: Tue, 4 Sep 2018 15:21:26 +0200
+Subject: [PATCH] Makefile: fix parallel build failure
+
+When issuing make -j build fails reporting:
+parsetime.l:5:10: fatal error: y.tab.h: No such file or directory
+This is because parsetime.l is compiled without waiting for y.tab.h file
+to be created.
+
+Add parsetime.l dependency to y.tab.h in Makefile.in
+
+Signed-off-by: Giulio Benetti <[hidden email]>
+---
+ Makefile.in | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/Makefile.in b/Makefile.in
+index 4c11913..18ecc23 100644
+--- a/Makefile.in
++++ b/Makefile.in
+@@ -83,6 +83,8 @@ y.tab.c y.tab.h: parsetime.y
+ lex.yy.c: parsetime.l
+ $(LEX) -i parsetime.l
+
++parsetime.l: y.tab.h
++
+ atd.service: atd.service.in
+ cat $< | sed -e 's![@]sbindir[@]!$(sbindir)!g' | sed -e 's![@]atjobdir[@]!$(atjobdir)!g' > $@
+
+--
+2.17.1
+
diff --git a/package/at/at.hash b/package/at/at.hash
index 22c732cc7e..e6eb26d818 100644
--- a/package/at/at.hash
+++ b/package/at/at.hash
@@ -1,2 +1,2 @@
-# From: http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at/at_3.1.16-1.dsc
-sha256 cb9af59c6a54edce9536ba629841055409d1f89d8ae26494727a97141fb4d5c1  at_3.1.16.orig.tar.gz
+# Locally calculated
+sha256 f5c7c8226fab0bc4e2d16a55e04d4026f3452db51fc5cbcc4bb5a3c79a79f7ef  at-release_3.1.23.tar.gz
diff --git a/package/at/at.mk b/package/at/at.mk
index 058ebac5c8..1d42b27b03 100644
--- a/package/at/at.mk
+++ b/package/at/at.mk
@@ -4,10 +4,11 @@
 #
 ################################################################################
 
-AT_VERSION = 3.1.16
-AT_SOURCE = at_$(AT_VERSION).orig.tar.gz
-AT_SITE = http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at
-# missing deps for parsetime.l
+AT_VERSION = release/3.1.23
+AT_SITE = https://salsa.debian.org/debian/at.git
+AT_SITE_METHOD = git
+# added missing deps for parsetime.l but still parallel build fails in some
+# case, so at the moment let's keep MAKE1
 AT_MAKE = $(MAKE1)
 AT_AUTORECONF = YES
 AT_DEPENDENCIES = $(if $(BR2_PACKAGE_FLEX),flex) host-bison host-flex
--
2.17.1

_______________________________________________
buildroot mailing list
[hidden email]
http://lists.busybox.net/mailman/listinfo/buildroot
Reply | Threaded
Open this post in threaded view
|

[PATCH 2/2] at: add sha256 for legal-info files

Giulio Benetti
In reply to this post by Giulio Benetti
Copyright and COPYING file sha256 are missing.

Add them calculating locally.

Signed-off-by: Giulio Benetti <[hidden email]>
---
 package/at/at.hash | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/package/at/at.hash b/package/at/at.hash
index e6eb26d818..530b1257c1 100644
--- a/package/at/at.hash
+++ b/package/at/at.hash
@@ -1,2 +1,5 @@
 # Locally calculated
 sha256 f5c7c8226fab0bc4e2d16a55e04d4026f3452db51fc5cbcc4bb5a3c79a79f7ef  at-release_3.1.23.tar.gz
+
+sha256 01dccc0975aa9ba1a9f83e7c5e04f16077353d3c72a0a759b8846ee7a5b2b616  Copyright
+sha256 c38aee9e3c8c4d5d594ff548a1be05453023016d6286931f6512db215ec1fd42  COPYING
--
2.17.1

_______________________________________________
buildroot mailing list
[hidden email]
http://lists.busybox.net/mailman/listinfo/buildroot
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 1/2] at: change upstream site, bump version

Thomas Petazzoni
In reply to this post by Giulio Benetti
Hello,

Thanks for working on this! This was definitely something that needed
to be done for a long time!

On Mon, 17 Sep 2018 23:12:18 +0200, Giulio Benetti wrote:
> Minicom is now available on a git repository at:

Minicom ? :-)

> https://salsa.debian.org/debian/at
> Main changes 3.1.16 -> 3.1.23:
> - add support for SELinux, multiple files
> - improve atd.service, see bug report 892819
> - fix various bugs and warnings
> - finalized script to release software
>
> So:
> - change AT_SITE_METHOD to git pointing to release/3.1.23
> - update tarball sha256 in hash file
>
> Signed-off-by: Giulio Benetti <[hidden email]>
> ---
>  ...-Makefile-fix-parallel-build-failure.patch | 33 +++++++++++++++++++

Is it really necessary to have a patch that fixes parallel build, if
parallel build is not entirely fixed and you need $(MAKE1) anyway ?

I believe the patch is not necessary. Let's keep MAKE1 for now, and
maybe report the parallel build issue upstream.

Thanks!

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[hidden email]
http://lists.busybox.net/mailman/listinfo/buildroot
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 1/2] at: change upstream site, bump version

Giulio Benetti
Il 18/09/2018 09:57, Thomas Petazzoni ha scritto:
> Hello,
>
> Thanks for working on this! This was definitely something that needed
> to be done for a long time!
>
> On Mon, 17 Sep 2018 23:12:18 +0200, Giulio Benetti wrote:
>> Minicom is now available on a git repository at:
>
> Minicom ? :-)

Oops.

>
>> https://salsa.debian.org/debian/at
>> Main changes 3.1.16 -> 3.1.23:
>> - add support for SELinux, multiple files
>> - improve atd.service, see bug report 892819
>> - fix various bugs and warnings
>> - finalized script to release software
>>
>> So:
>> - change AT_SITE_METHOD to git pointing to release/3.1.23
>> - update tarball sha256 in hash file
>>
>> Signed-off-by: Giulio Benetti <[hidden email]>
>> ---
>>   ...-Makefile-fix-parallel-build-failure.patch | 33 +++++++++++++++++++
>
> Is it really necessary to have a patch that fixes parallel build, if
> parallel build is not entirely fixed and you need $(MAKE1) anyway ?
>
> I believe the patch is not necessary. Let's keep MAKE1 for now, and
> maybe report the parallel build issue upstream.

Ok, I'm going to submit v2.

By the way, testing it on qemu and also a colleague found that on arm
board, atd needs .SEQ file before starting.
Do I have to add this to package?
I mean, if that file doesn't exists in target, then let's create it?

Thanks
Best regards
--
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale € 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
_______________________________________________
buildroot mailing list
[hidden email]
http://lists.busybox.net/mailman/listinfo/buildroot
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 1/2] at: change upstream site, bump version

Thomas Petazzoni
Hello,

On Tue, 18 Sep 2018 10:01:40 +0200, Giulio Benetti wrote:

> By the way, testing it on qemu and also a colleague found that on arm
> board, atd needs .SEQ file before starting.
> Do I have to add this to package?

What is this .SEQ file ?

Best regards,

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[hidden email]
http://lists.busybox.net/mailman/listinfo/buildroot
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 1/2] at: change upstream site, bump version

Giulio Benetti
Hello,

Il 18/09/2018 11:16, Thomas Petazzoni ha scritto:
> Hello,
>
> On Tue, 18 Sep 2018 10:01:40 +0200, Giulio Benetti wrote:
>
>> By the way, testing it on qemu and also a colleague found that on arm
>> board, atd needs .SEQ file before starting.
>> Do I have to add this to package?
>
> What is this .SEQ file ?

/var/spool/cron/atjobs/.SEQ is a necessary file for atd which keeps
status of scheduled jobs.
If atd doesn't find that file fails to run instead of creating it
empty(this is the solution to make it work).
So better add:
touch /var/spool/cron/atjobs/.SEQ on target_dir
to the package.

So I've answered myself :)

--
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale € 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
_______________________________________________
buildroot mailing list
[hidden email]
http://lists.busybox.net/mailman/listinfo/buildroot
Reply | Threaded
Open this post in threaded view
|

[PATCH v2 0/2] at: bump version

Giulio Benetti
In reply to this post by Thomas Petazzoni
As suggested at https://elinux.org/Buildroot#Todo_list:
"Update the at package to use the upstream.
http://anonscm.debian.org/gitweb/?p=collab-maint/at.git;a=summary"
In the meanwhile that site became unreachable and the at upstream now is:
https://salsa.debian.org/debian/at

These are the basic tasks done:
- change upstream site, bump version
- add sha256 for legal-info files
- improved S99at init.d script to have live session working
  (/var/spool linked to /tmp) and warn about it

Giulio Benetti (2):
  at: change upstream site, bump version
  at: add sha256 for legal-info files

 package/at/S99at   |  9 +++++++++
 package/at/at.hash |  7 +++++--
 package/at/at.mk   | 10 ++++++----
 3 files changed, 20 insertions(+), 6 deletions(-)

--
2.17.1

_______________________________________________
buildroot mailing list
[hidden email]
http://lists.busybox.net/mailman/listinfo/buildroot
Reply | Threaded
Open this post in threaded view
|

[PATCH v2 1/2] at: change upstream site, bump version

Giulio Benetti
At is now available on a git repository at:
https://salsa.debian.org/debian/at
Main changes 3.1.16 -> 3.1.23:
- add support for SELinux, multiple files
- improve atd.service, see bug report 892819
- fix various bugs and warnings
- finalized script to release software

So:
- change AT_SITE_METHOD to git pointing to release/3.1.23
- update tarball sha256 in hash file
- improved S99at script:
  if /var/spool is linked to /tmp, .SEQ file will be lost and atd won't
  work neither for a live session. Create .SEQ file if not found, warning
  during start that after reboot atjobs could be lost.

Signed-off-by: Giulio Benetti <[hidden email]>
---
 package/at/S99at   |  9 +++++++++
 package/at/at.hash |  4 ++--
 package/at/at.mk   | 10 ++++++----
 3 files changed, 17 insertions(+), 6 deletions(-)

diff --git a/package/at/S99at b/package/at/S99at
index 666d39b546..fb81736ae2 100755
--- a/package/at/S99at
+++ b/package/at/S99at
@@ -6,6 +6,15 @@
 umask 077
 
 start() {
+ # Since /va/spool can be linked to /tmp (tmpfs)
+ # /var/spool/cron/atjobs/.SEQ created could be not available
+ # Check if not exists otherwise create it
+ if [ ! -f /var/spool/cron/atjobs/.SEQ ]; then
+    mkdir -p /var/spool/cron/atjobs/
+    touch /var/spool/cron/atjobs/.SEQ
+    printf "atd: Created missing .SEQ file. Probably it's in tmpfs and on reboot atjobs will be lost!\n"
+ fi
+
  printf "Starting atd: "
  start-stop-daemon --start --quiet --make-pidfile --pidfile /var/run/atd.pid --background --exec /usr/sbin/atd -- -f
  echo "OK"
diff --git a/package/at/at.hash b/package/at/at.hash
index 22c732cc7e..e6eb26d818 100644
--- a/package/at/at.hash
+++ b/package/at/at.hash
@@ -1,2 +1,2 @@
-# From: http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at/at_3.1.16-1.dsc
-sha256 cb9af59c6a54edce9536ba629841055409d1f89d8ae26494727a97141fb4d5c1  at_3.1.16.orig.tar.gz
+# Locally calculated
+sha256 f5c7c8226fab0bc4e2d16a55e04d4026f3452db51fc5cbcc4bb5a3c79a79f7ef  at-release_3.1.23.tar.gz
diff --git a/package/at/at.mk b/package/at/at.mk
index 058ebac5c8..083fbbc74b 100644
--- a/package/at/at.mk
+++ b/package/at/at.mk
@@ -4,10 +4,11 @@
 #
 ################################################################################
 
-AT_VERSION = 3.1.16
-AT_SOURCE = at_$(AT_VERSION).orig.tar.gz
-AT_SITE = http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at
-# missing deps for parsetime.l
+AT_VERSION = release/3.1.23
+AT_SITE = https://salsa.debian.org/debian/at.git
+AT_SITE_METHOD = git
+# Tried to add missing deps for parsetime.l but still parallel build fails
+# in some case, so at the moment let's keep MAKE1
 AT_MAKE = $(MAKE1)
 AT_AUTORECONF = YES
 AT_DEPENDENCIES = $(if $(BR2_PACKAGE_FLEX),flex) host-bison host-flex
@@ -23,6 +24,7 @@ AT_CONF_OPTS = \
 
 define AT_INSTALL_INIT_SYSV
  $(INSTALL) -m 0755 -D package/at/S99at $(TARGET_DIR)/etc/init.d/S99at
+
 endef
 
 $(eval $(autotools-package))
--
2.17.1

_______________________________________________
buildroot mailing list
[hidden email]
http://lists.busybox.net/mailman/listinfo/buildroot
Reply | Threaded
Open this post in threaded view
|

[PATCH v2 2/2] at: add sha256 for legal-info files

Giulio Benetti
In reply to this post by Giulio Benetti
Copyright and COPYING file sha256 are missing.

Add them calculating locally.

Signed-off-by: Giulio Benetti <[hidden email]>
---
 package/at/at.hash | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/package/at/at.hash b/package/at/at.hash
index e6eb26d818..530b1257c1 100644
--- a/package/at/at.hash
+++ b/package/at/at.hash
@@ -1,2 +1,5 @@
 # Locally calculated
 sha256 f5c7c8226fab0bc4e2d16a55e04d4026f3452db51fc5cbcc4bb5a3c79a79f7ef  at-release_3.1.23.tar.gz
+
+sha256 01dccc0975aa9ba1a9f83e7c5e04f16077353d3c72a0a759b8846ee7a5b2b616  Copyright
+sha256 c38aee9e3c8c4d5d594ff548a1be05453023016d6286931f6512db215ec1fd42  COPYING
--
2.17.1

_______________________________________________
buildroot mailing list
[hidden email]
http://lists.busybox.net/mailman/listinfo/buildroot
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v2 1/2] at: change upstream site, bump version

Giulio Benetti
In reply to this post by Giulio Benetti
Forgot to mention V1->V2 Changes:
- removed patch for parallel build since it doesn't work in every case
- improved s99at script to have atd working in live session warning
   about that after reboot atjobs will be lost.

Sorry.
Kind regards
--
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale € 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642

Il 18/09/2018 23:39, Giulio Benetti ha scritto:

> At is now available on a git repository at:
> https://salsa.debian.org/debian/at
> Main changes 3.1.16 -> 3.1.23:
> - add support for SELinux, multiple files
> - improve atd.service, see bug report 892819
> - fix various bugs and warnings
> - finalized script to release software
>
> So:
> - change AT_SITE_METHOD to git pointing to release/3.1.23
> - update tarball sha256 in hash file
> - improved S99at script:
>    if /var/spool is linked to /tmp, .SEQ file will be lost and atd won't
>    work neither for a live session. Create .SEQ file if not found, warning
>    during start that after reboot atjobs could be lost.
>
> Signed-off-by: Giulio Benetti <[hidden email]>
> ---
>   package/at/S99at   |  9 +++++++++
>   package/at/at.hash |  4 ++--
>   package/at/at.mk   | 10 ++++++----
>   3 files changed, 17 insertions(+), 6 deletions(-)
>
> diff --git a/package/at/S99at b/package/at/S99at
> index 666d39b546..fb81736ae2 100755
> --- a/package/at/S99at
> +++ b/package/at/S99at
> @@ -6,6 +6,15 @@
>   umask 077
>  
>   start() {
> + # Since /va/spool can be linked to /tmp (tmpfs)
> + # /var/spool/cron/atjobs/.SEQ created could be not available
> + # Check if not exists otherwise create it
> + if [ ! -f /var/spool/cron/atjobs/.SEQ ]; then
> +    mkdir -p /var/spool/cron/atjobs/
> +    touch /var/spool/cron/atjobs/.SEQ
> +    printf "atd: Created missing .SEQ file. Probably it's in tmpfs and on reboot atjobs will be lost!\n"
> + fi
> +
>   printf "Starting atd: "
>   start-stop-daemon --start --quiet --make-pidfile --pidfile /var/run/atd.pid --background --exec /usr/sbin/atd -- -f
>   echo "OK"
> diff --git a/package/at/at.hash b/package/at/at.hash
> index 22c732cc7e..e6eb26d818 100644
> --- a/package/at/at.hash
> +++ b/package/at/at.hash
> @@ -1,2 +1,2 @@
> -# From: http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at/at_3.1.16-1.dsc
> -sha256 cb9af59c6a54edce9536ba629841055409d1f89d8ae26494727a97141fb4d5c1  at_3.1.16.orig.tar.gz
> +# Locally calculated
> +sha256 f5c7c8226fab0bc4e2d16a55e04d4026f3452db51fc5cbcc4bb5a3c79a79f7ef  at-release_3.1.23.tar.gz
> diff --git a/package/at/at.mk b/package/at/at.mk
> index 058ebac5c8..083fbbc74b 100644
> --- a/package/at/at.mk
> +++ b/package/at/at.mk
> @@ -4,10 +4,11 @@
>   #
>   ################################################################################
>  
> -AT_VERSION = 3.1.16
> -AT_SOURCE = at_$(AT_VERSION).orig.tar.gz
> -AT_SITE = http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at
> -# missing deps for parsetime.l
> +AT_VERSION = release/3.1.23
> +AT_SITE = https://salsa.debian.org/debian/at.git
> +AT_SITE_METHOD = git
> +# Tried to add missing deps for parsetime.l but still parallel build fails
> +# in some case, so at the moment let's keep MAKE1
>   AT_MAKE = $(MAKE1)
>   AT_AUTORECONF = YES
>   AT_DEPENDENCIES = $(if $(BR2_PACKAGE_FLEX),flex) host-bison host-flex
> @@ -23,6 +24,7 @@ AT_CONF_OPTS = \
>  
>   define AT_INSTALL_INIT_SYSV
>   $(INSTALL) -m 0755 -D package/at/S99at $(TARGET_DIR)/etc/init.d/S99at
> +
>   endef
>  
>   $(eval $(autotools-package))
>
_______________________________________________
buildroot mailing list
[hidden email]
http://lists.busybox.net/mailman/listinfo/buildroot
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v2 0/2] at: bump version

Giulio Benetti
In reply to this post by Giulio Benetti
Hello,

I've just opened a Merge Request upstream:
https://salsa.debian.org/debian/at/merge_requests/3

I invite everybody to place a "like" on Merge Request

Thanks
Kind regards

--
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale € 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642

Il 18/09/2018 23:39, Giulio Benetti ha scritto:

> As suggested at https://elinux.org/Buildroot#Todo_list:
> "Update the at package to use the upstream.
> http://anonscm.debian.org/gitweb/?p=collab-maint/at.git;a=summary"
> In the meanwhile that site became unreachable and the at upstream now is:
> https://salsa.debian.org/debian/at
>
> These are the basic tasks done:
> - change upstream site, bump version
> - add sha256 for legal-info files
> - improved S99at init.d script to have live session working
>    (/var/spool linked to /tmp) and warn about it
>
> Giulio Benetti (2):
>    at: change upstream site, bump version
>    at: add sha256 for legal-info files
>
>   package/at/S99at   |  9 +++++++++
>   package/at/at.hash |  7 +++++--
>   package/at/at.mk   | 10 ++++++----
>   3 files changed, 20 insertions(+), 6 deletions(-)
>

_______________________________________________
buildroot mailing list
[hidden email]
http://lists.busybox.net/mailman/listinfo/buildroot
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v2 1/2] at: change upstream site, bump version

Baruch Siach
In reply to this post by Giulio Benetti
Hi Giulio,

On Tue, Sep 18, 2018 at 11:39:48PM +0200, Giulio Benetti wrote:

> At is now available on a git repository at:
> https://salsa.debian.org/debian/at
> Main changes 3.1.16 -> 3.1.23:
> - add support for SELinux, multiple files
> - improve atd.service, see bug report 892819
> - fix various bugs and warnings
> - finalized script to release software
>
> So:
> - change AT_SITE_METHOD to git pointing to release/3.1.23
> - update tarball sha256 in hash file
> - improved S99at script:
>   if /var/spool is linked to /tmp, .SEQ file will be lost and atd won't
>   work neither for a live session. Create .SEQ file if not found, warning
>   during start that after reboot atjobs could be lost.
>
> Signed-off-by: Giulio Benetti <[hidden email]>
> ---
>  package/at/S99at   |  9 +++++++++
>  package/at/at.hash |  4 ++--
>  package/at/at.mk   | 10 ++++++----
>  3 files changed, 17 insertions(+), 6 deletions(-)
>
> diff --git a/package/at/S99at b/package/at/S99at
> index 666d39b546..fb81736ae2 100755
> --- a/package/at/S99at
> +++ b/package/at/S99at
> @@ -6,6 +6,15 @@
>  umask 077
>  
>  start() {
> + # Since /va/spool can be linked to /tmp (tmpfs)

va -> var

> + # /var/spool/cron/atjobs/.SEQ created could be not available
> + # Check if not exists otherwise create it
> + if [ ! -f /var/spool/cron/atjobs/.SEQ ]; then
> +    mkdir -p /var/spool/cron/atjobs/
> +    touch /var/spool/cron/atjobs/.SEQ
> +    printf "atd: Created missing .SEQ file. Probably it's in tmpfs and on reboot atjobs will be lost!\n"
> + fi
> +
>   printf "Starting atd: "
>   start-stop-daemon --start --quiet --make-pidfile --pidfile /var/run/atd.pid --background --exec /usr/sbin/atd -- -f
>   echo "OK"
> diff --git a/package/at/at.hash b/package/at/at.hash
> index 22c732cc7e..e6eb26d818 100644
> --- a/package/at/at.hash
> +++ b/package/at/at.hash
> @@ -1,2 +1,2 @@
> -# From: http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at/at_3.1.16-1.dsc
> -sha256 cb9af59c6a54edce9536ba629841055409d1f89d8ae26494727a97141fb4d5c1  at_3.1.16.orig.tar.gz
> +# Locally calculated
> +sha256 f5c7c8226fab0bc4e2d16a55e04d4026f3452db51fc5cbcc4bb5a3c79a79f7ef  at-release_3.1.23.tar.gz
> diff --git a/package/at/at.mk b/package/at/at.mk
> index 058ebac5c8..083fbbc74b 100644
> --- a/package/at/at.mk
> +++ b/package/at/at.mk
> @@ -4,10 +4,11 @@
>  #
>  ################################################################################
>  
> -AT_VERSION = 3.1.16
> -AT_SOURCE = at_$(AT_VERSION).orig.tar.gz
> -AT_SITE = http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at
> -# missing deps for parsetime.l
> +AT_VERSION = release/3.1.23
> +AT_SITE = https://salsa.debian.org/debian/at.git
> +AT_SITE_METHOD = git
> +# Tried to add missing deps for parsetime.l but still parallel build fails
> +# in some case, so at the moment let's keep MAKE1
>  AT_MAKE = $(MAKE1)
>  AT_AUTORECONF = YES
>  AT_DEPENDENCIES = $(if $(BR2_PACKAGE_FLEX),flex) host-bison host-flex
> @@ -23,6 +24,7 @@ AT_CONF_OPTS = \
>  
>  define AT_INSTALL_INIT_SYSV
>   $(INSTALL) -m 0755 -D package/at/S99at $(TARGET_DIR)/etc/init.d/S99at
> +

Redundant newline.

>  endef
>  
>  $(eval $(autotools-package))

baruch

--
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - [hidden email] - tel: +972.2.679.5364, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
[hidden email]
http://lists.busybox.net/mailman/listinfo/buildroot
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v2 1/2] at: change upstream site, bump version

Matthew Weber-3
In reply to this post by Giulio Benetti
Giulio,


On Tue, Sep 18, 2018 at 4:40 PM Giulio Benetti
<[hidden email]> wrote:
>
> At is now available on a git repository at:
> https://salsa.debian.org/debian/at
> Main changes 3.1.16 -> 3.1.23:
> - add support for SELinux, multiple files
> - improve atd.service, see bug report 892819
> - fix various bugs and warnings
> - finalized script to release software

Please update the Config.in to list a valid url for this package.

Maybe https://salsa.debian.org/debian/at  or https://tracker.debian.org/pkg/at ?

Matt
_______________________________________________
buildroot mailing list
[hidden email]
http://lists.busybox.net/mailman/listinfo/buildroot
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v2 1/2] at: change upstream site, bump version

Giulio Benetti
In reply to this post by Baruch Siach
Hi Baruch,

Il 20/09/2018 06:38, Baruch Siach ha scritto:

> Hi Giulio,
>
> On Tue, Sep 18, 2018 at 11:39:48PM +0200, Giulio Benetti wrote:
>> At is now available on a git repository at:
>> https://salsa.debian.org/debian/at
>> Main changes 3.1.16 -> 3.1.23:
>> - add support for SELinux, multiple files
>> - improve atd.service, see bug report 892819
>> - fix various bugs and warnings
>> - finalized script to release software
>>
>> So:
>> - change AT_SITE_METHOD to git pointing to release/3.1.23
>> - update tarball sha256 in hash file
>> - improved S99at script:
>>    if /var/spool is linked to /tmp, .SEQ file will be lost and atd won't
>>    work neither for a live session. Create .SEQ file if not found, warning
>>    during start that after reboot atjobs could be lost.
>>
>> Signed-off-by: Giulio Benetti <[hidden email]>
>> ---
>>   package/at/S99at   |  9 +++++++++
>>   package/at/at.hash |  4 ++--
>>   package/at/at.mk   | 10 ++++++----
>>   3 files changed, 17 insertions(+), 6 deletions(-)
>>
>> diff --git a/package/at/S99at b/package/at/S99at
>> index 666d39b546..fb81736ae2 100755
>> --- a/package/at/S99at
>> +++ b/package/at/S99at
>> @@ -6,6 +6,15 @@
>>   umask 077
>>  
>>   start() {
>> + # Since /va/spool can be linked to /tmp (tmpfs)
>
> va -> var

Oops, yes.

>
>> + # /var/spool/cron/atjobs/.SEQ created could be not available
>> + # Check if not exists otherwise create it
>> + if [ ! -f /var/spool/cron/atjobs/.SEQ ]; then
>> +    mkdir -p /var/spool/cron/atjobs/
>> +    touch /var/spool/cron/atjobs/.SEQ
>> +    printf "atd: Created missing .SEQ file. Probably it's in tmpfs and on reboot atjobs will be lost!\n"
>> + fi
>> +
>>   printf "Starting atd: "
>>   start-stop-daemon --start --quiet --make-pidfile --pidfile /var/run/atd.pid --background --exec /usr/sbin/atd -- -f
>>   echo "OK"
>> diff --git a/package/at/at.hash b/package/at/at.hash
>> index 22c732cc7e..e6eb26d818 100644
>> --- a/package/at/at.hash
>> +++ b/package/at/at.hash
>> @@ -1,2 +1,2 @@
>> -# From: http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at/at_3.1.16-1.dsc
>> -sha256 cb9af59c6a54edce9536ba629841055409d1f89d8ae26494727a97141fb4d5c1  at_3.1.16.orig.tar.gz
>> +# Locally calculated
>> +sha256 f5c7c8226fab0bc4e2d16a55e04d4026f3452db51fc5cbcc4bb5a3c79a79f7ef  at-release_3.1.23.tar.gz
>> diff --git a/package/at/at.mk b/package/at/at.mk
>> index 058ebac5c8..083fbbc74b 100644
>> --- a/package/at/at.mk
>> +++ b/package/at/at.mk
>> @@ -4,10 +4,11 @@
>>   #
>>   ################################################################################
>>  
>> -AT_VERSION = 3.1.16
>> -AT_SOURCE = at_$(AT_VERSION).orig.tar.gz
>> -AT_SITE = http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at
>> -# missing deps for parsetime.l
>> +AT_VERSION = release/3.1.23
>> +AT_SITE = https://salsa.debian.org/debian/at.git
>> +AT_SITE_METHOD = git
>> +# Tried to add missing deps for parsetime.l but still parallel build fails
>> +# in some case, so at the moment let's keep MAKE1
>>   AT_MAKE = $(MAKE1)
>>   AT_AUTORECONF = YES
>>   AT_DEPENDENCIES = $(if $(BR2_PACKAGE_FLEX),flex) host-bison host-flex
>> @@ -23,6 +24,7 @@ AT_CONF_OPTS = \
>>  
>>   define AT_INSTALL_INIT_SYSV
>>   $(INSTALL) -m 0755 -D package/at/S99at $(TARGET_DIR)/etc/init.d/S99at
>> +
>
> Redundant newline.

Yep

Thank you!
Best regards
--
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale € 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
_______________________________________________
buildroot mailing list
[hidden email]
http://lists.busybox.net/mailman/listinfo/buildroot
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v2 1/2] at: change upstream site, bump version

Giulio Benetti
In reply to this post by Matthew Weber-3
Il 20/09/2018 14:43, Matthew Weber ha scritto:

> Giulio,
>
>
> On Tue, Sep 18, 2018 at 4:40 PM Giulio Benetti
> <[hidden email]> wrote:
>>
>> At is now available on a git repository at:
>> https://salsa.debian.org/debian/at
>> Main changes 3.1.16 -> 3.1.23:
>> - add support for SELinux, multiple files
>> - improve atd.service, see bug report 892819
>> - fix various bugs and warnings
>> - finalized script to release software
>
> Please update the Config.in to list a valid url for this package.
>
> Maybe https://salsa.debian.org/debian/at  or https://tracker.debian.org/pkg/at ?

I correct it.

Thank you.
Best regards
--
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale € 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
_______________________________________________
buildroot mailing list
[hidden email]
http://lists.busybox.net/mailman/listinfo/buildroot
Reply | Threaded
Open this post in threaded view
|

[PATCH v3 0/2] at: bump version

Giulio Benetti
In reply to this post by Giulio Benetti
As suggested at https://elinux.org/Buildroot#Todo_list:
"Update the at package to use the upstream.
http://anonscm.debian.org/gitweb/?p=collab-maint/at.git;a=summary"
In the meanwhile that site became unreachable and the at upstream now is:
https://salsa.debian.org/debian/at

These are the basic tasks done:
- change upstream site, bump version
- add sha256 for legal-info files
- improved S99at init.d script to have live session working
  (/var/spool linked to /tmp) and warn about it

Giulio Benetti (2):
  at: change upstream site, bump version
  at: add sha256 for legal-info files

 package/at/Config.in | 2 ++
 package/at/S99at     | 9 +++++++++
 package/at/at.hash   | 7 +++++--
 package/at/at.mk     | 9 +++++----
 4 files changed, 21 insertions(+), 6 deletions(-)

--
2.17.1

_______________________________________________
buildroot mailing list
[hidden email]
http://lists.busybox.net/mailman/listinfo/buildroot
Reply | Threaded
Open this post in threaded view
|

[PATCH v3 1/2] at: change upstream site, bump version

Giulio Benetti
At is now available on a git repository at:
https://salsa.debian.org/debian/at
Main changes 3.1.16 -> 3.1.23:
- add support for SELinux, multiple files
- improve atd.service, see bug report 892819
- fix various bugs and warnings
- finalized script to release software

So:
- change AT_SITE_METHOD to git pointing to release/3.1.23
- update tarball sha256 in hash file
- improved S99at script:
  if /var/spool is linked to /tmp, .SEQ file will be lost and atd won't
  work neither for a live session. Create .SEQ file if not found, warning
  during start that after reboot atjobs could be lost.

Signed-off-by: Giulio Benetti <[hidden email]>
---
Changes V2->V3:
* correct comment in S99at script
* remove redundant newline in at.mk
* add website to Config.in

 package/at/Config.in | 2 ++
 package/at/S99at     | 9 +++++++++
 package/at/at.hash   | 4 ++--
 package/at/at.mk     | 9 +++++----
 4 files changed, 18 insertions(+), 6 deletions(-)

diff --git a/package/at/Config.in b/package/at/Config.in
index 17fabf7f6b..cbc5be47b8 100644
--- a/package/at/Config.in
+++ b/package/at/Config.in
@@ -8,3 +8,5 @@ config BR2_PACKAGE_AT
 
   at    - run the job at a specified time
   batch - run the job when system load levels permit
+
+  https://salsa.debian.org/debian/at
diff --git a/package/at/S99at b/package/at/S99at
index 666d39b546..a5015b0735 100755
--- a/package/at/S99at
+++ b/package/at/S99at
@@ -6,6 +6,15 @@
 umask 077
 
 start() {
+ # Since /var/spool can be linked to /tmp (tmpfs)
+ # /var/spool/cron/atjobs/.SEQ created could be not available
+ # Check if not exists otherwise create it
+ if [ ! -f /var/spool/cron/atjobs/.SEQ ]; then
+    mkdir -p /var/spool/cron/atjobs/
+    touch /var/spool/cron/atjobs/.SEQ
+    printf "atd: Created missing .SEQ file. Probably it's in tmpfs and on reboot atjobs will be lost!\n"
+ fi
+
  printf "Starting atd: "
  start-stop-daemon --start --quiet --make-pidfile --pidfile /var/run/atd.pid --background --exec /usr/sbin/atd -- -f
  echo "OK"
diff --git a/package/at/at.hash b/package/at/at.hash
index 22c732cc7e..e6eb26d818 100644
--- a/package/at/at.hash
+++ b/package/at/at.hash
@@ -1,2 +1,2 @@
-# From: http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at/at_3.1.16-1.dsc
-sha256 cb9af59c6a54edce9536ba629841055409d1f89d8ae26494727a97141fb4d5c1  at_3.1.16.orig.tar.gz
+# Locally calculated
+sha256 f5c7c8226fab0bc4e2d16a55e04d4026f3452db51fc5cbcc4bb5a3c79a79f7ef  at-release_3.1.23.tar.gz
diff --git a/package/at/at.mk b/package/at/at.mk
index 058ebac5c8..36aa8c7a42 100644
--- a/package/at/at.mk
+++ b/package/at/at.mk
@@ -4,10 +4,11 @@
 #
 ################################################################################
 
-AT_VERSION = 3.1.16
-AT_SOURCE = at_$(AT_VERSION).orig.tar.gz
-AT_SITE = http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at
-# missing deps for parsetime.l
+AT_VERSION = release/3.1.23
+AT_SITE = https://salsa.debian.org/debian/at.git
+AT_SITE_METHOD = git
+# Tried to add missing deps for parsetime.l but still parallel build fails
+# in some case, so at the moment let's keep MAKE1
 AT_MAKE = $(MAKE1)
 AT_AUTORECONF = YES
 AT_DEPENDENCIES = $(if $(BR2_PACKAGE_FLEX),flex) host-bison host-flex
--
2.17.1

_______________________________________________
buildroot mailing list
[hidden email]
http://lists.busybox.net/mailman/listinfo/buildroot
Reply | Threaded
Open this post in threaded view
|

[PATCH v3 2/2] at: add sha256 for legal-info files

Giulio Benetti
In reply to this post by Giulio Benetti
Copyright and COPYING file sha256 are missing.

Add them calculating locally.

Signed-off-by: Giulio Benetti <[hidden email]>
---
 package/at/at.hash | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/package/at/at.hash b/package/at/at.hash
index e6eb26d818..530b1257c1 100644
--- a/package/at/at.hash
+++ b/package/at/at.hash
@@ -1,2 +1,5 @@
 # Locally calculated
 sha256 f5c7c8226fab0bc4e2d16a55e04d4026f3452db51fc5cbcc4bb5a3c79a79f7ef  at-release_3.1.23.tar.gz
+
+sha256 01dccc0975aa9ba1a9f83e7c5e04f16077353d3c72a0a759b8846ee7a5b2b616  Copyright
+sha256 c38aee9e3c8c4d5d594ff548a1be05453023016d6286931f6512db215ec1fd42  COPYING
--
2.17.1

_______________________________________________
buildroot mailing list
[hidden email]
http://lists.busybox.net/mailman/listinfo/buildroot
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v3 1/2] at: change upstream site, bump version

Matthew Weber-3
In reply to this post by Giulio Benetti
Giulio,

On Thu, Sep 20, 2018 at 11:59 AM Giulio Benetti
<[hidden email]> wrote:

>
> At is now available on a git repository at:
> https://salsa.debian.org/debian/at
> Main changes 3.1.16 -> 3.1.23:
> - add support for SELinux, multiple files
> - improve atd.service, see bug report 892819
> - fix various bugs and warnings
> - finalized script to release software
>
> So:
> - change AT_SITE_METHOD to git pointing to release/3.1.23
> - update tarball sha256 in hash file
> - improved S99at script:
>   if /var/spool is linked to /tmp, .SEQ file will be lost and atd won't
>   work neither for a live session. Create .SEQ file if not found, warning
>   during start that after reboot atjobs could be lost.
>
> Signed-off-by: Giulio Benetti <[hidden email]>

Reviewed-by: Matt Weber <[hidden email]>
_______________________________________________
buildroot mailing list
[hidden email]
http://lists.busybox.net/mailman/listinfo/buildroot
12